Open isXander opened 1 year ago
Still don't know any use cases outside that one Hypixel minigame where this would be still needed.
Why was Debugify's fix and tooltipfix added in the past?
Because it was an issue in the past and people convinced me to add it. But in 1.19.3 snapshot Mojang fixed it - not perfectly, but covers 90%+ of use cases imo.
So - I need more convincing about the big bad use cases that Mojang's fix does not cover.
Mojang didn't fix it. All they did was prevent it going off the left side of the screen.
This is bad for a few reasons:
Also, you must remember, tooltips can appear in other aspects of the game other than the inventory, it can help other mods too.
Tooltips would cover up a whole row in the inventory, including the item the user is hovering over.
That's a minor visual detail, which can be but does not necessarily have to be fixed.
It can still happen; if a line is just a little longer than in 1.19.2, it will still go off-screen (and look bad) Also, you must remember, tooltips can appear in other aspects of the game other than the inventory, it can help other mods too.
Indeed, that is the theory. Now I want practical examples to prove it (as of 1.19.3).
Alright, did some quick testing - here's the results:
The vanilla instances were adjusted to use GUI scale 3 to match the default FO.
Command if you want to test yourself: give <user> stick{display:{Name:'{"text":"this is a very long tooltipthis is a very long tooltipthis is a very long tooltipthis is a very long tooltipthis is a very long tooltipthis is a very long tooltipthis is a very long tooltipthis is a very long tooltipthis is a very long tooltipthis is a very long tooltipthis is a very long tooltipthis is a very long tooltipthis is a very long tooltipthis is a very long tooltipthis is a very long tooltipthis is a very long tooltipthis is a very long tooltipthis is a very long tooltipthis is a very long tooltip"}'}}
FO 4.5.2 (fixes it the right way IMO):
Vanilla 1.19.2 (for comparison only):
Vanilla 22w46a:
TL;DR Mojang doesn't wrap tooltips which is needed here.
I have a friend who made a game with one item having an extremely large tooltip, so I'll retest it if I can get my hands on said item now (which may qualify more as a 'practical example').
Those long lines of text are an easy way to demonstrate the possibility of recreating the problem, but not prove it in practice.
In survival, it is not possible to do this. Minigame servers, custom maps and datapacks would not intentionally do this.
So I want examples where actual content would accidentally overflow.
In singleplayer survival it wouldn't. But FO isn't just that and there are an infinite amount of servers that would.
What I don't understand is why you previously added these other mods/fixes. I don't see any situation where 1.19.3 fix would actually change anything in those scenarios.
Languages with long words? That was used when suggesting tooltipfix.
What I don't understand is why you previously added these other mods/fixes. I don't see any situation where 1.19.3 fix would actually change anything in those scenarios.
The mods were added primarily for the alignment, with wrapping being a bonus. Now I feel that because the alignment is fixed, the necessity of including a new mod just for wrapping needs to be elaborated - where is wrapping still critical and simple alignment is insufficient?
there are an infinite amount of servers that would. Languages with long words?
Screenshots?
play.wynncraft.net at FO default GUI scale: |
Resolution ---> v Version v |
854x480 (default) | 1920x1080 |
---|---|---|---|
Vanilla 1.19.2 | |||
1.19.2 with AT |
|||
Vanilla 1.19.3 (Wynncraft doesn't yet support 1.19.3) |
command: /give @p stick{display:{Lore:['"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"','"this is a tall tooltip"']}}
What I don't understand is why you previously added these other mods/fixes. I don't see any situation where 1.19.3 fix would actually change anything in those scenarios.
The mods were added primarily for the alignment, with wrapping being a bonus. Now I feel that because the alignment is fixed, the necessity of including a new mod just for wrapping needs to be elaborated - where is wrapping still critical and simple alignment is insufficient?
There is a lot more than just wrapping in AT:
And wrapping is also very versatile allowing the power user to decide which technique they like best: tooltipfix or debugify.
Also a lot to come for the 1.19.3 update, more info soon.
New features for 1.19.3:
As you can see AdaptiveTooltips is more than just wrapping and has a lot more of QOL that makes the game just feel easier to deal with.
Because it was an issue in the past and people convinced me to add it. But in 1.19.3 snapshot Mojang fixed it - not perfectly, but covers 90%+ of use cases imo.
So - I need more convincing about the big bad use cases that Mojang's fix does not cover.
What previous practical use cases got covered by this new .3 fix? Screenshots? I don't believe this fix actually does anything helpful.
Well, 4.6.0-alpha.1 is out so y'all can have a test how it works in vanilla now :P
Is there any interest for this on the upcoming beta(s)? @Madis0
No. 1.19.4 and even the April Fools snapshot showed that Mojang is taking tooltips more seriously now, so I don't see a need in a mod anymore.
Even the April Fools snapshot
How so?
buttons being Copy to clipboard
, Done
This will probably be properly introduced in the next 1.20 snapshot.
I hope they add something good, similar & serious (:trollface:) in vanilla, though this mod is super good
I don't think a whole screen is really a good solution.
I see the thumbs, so what things are still missing in vanilla 1.20.1?
Long tooltips can still get off-screen, Mojang's implementation is rather a workaround than a patch. When too long, tooltips are moved to the top left of the screen (which is also visually unpleasant for some people) and there, if they are even longer, they can still get cut off the screen. Adaptive Tooltips fixes that, tooltips stay on place without getting cut off and when they are too long, the is a tooltip scrolling option which can also be enabled. I think this sums it up..
CurseForge link
https://curseforge.com/minecraft/mc-mods/adaptive-tooltips
CurseForge Mod Distribution
Allowed
Modrinth link
https://modrinth.com/mod/adaptive-tooltips
Source/other link
https://github.com/isxander/adaptivetooltips
Mod file size
64.75 KB
License
(any other license)
What it does
AdaptiveTooltips contains various modifications to vanilla tooltips to allow users to always read them, no matter how badly implemented they are by server owners.
Why should it be in the modpack
It is a frequent problem where players cannot read large tooltips. This mod contains a a few tweaks that make sense for FO:
Screen Width
mode feels very natural with Bedrock Centering enabled whileRemaining Width
is similar to [tooltipfix]() that can feel a bit unnatural when you move the cursor.Why shouldn't it be in the modpack
This gives server owners an excuse to not implement better server-side handling of tooltips for vanilla users, however this shouldn't be FO's problem to enforce these kind of things and not being included in FO is unlikely to convince a server owner to do this.
Additional details
No response