search

Fabulously-Optimized / fabulously-optimized

A simple Minecraft modpack focusing on performance and graphics enhancements.
https://download.fo
BSD 3-Clause "New" or "Revised" License
917 stars 82 forks source link

Show Sodium donation button in video settings #701

Closed jellysquid3 closed 6 months ago

jellysquid3 commented 1 year ago

What config to change

As it appears here, you are shipping a config file which disables the prompt for a user to consider donating to our project. Please remove this config entry override so that users are shown the prompt again.

Why should it be changed

This is a single button in the video settings screen and should not bother anyone. If the user is bothered, they can click a single button (right next to our prompt) and permanently dismiss it.

Furthermore, you are the largest modpack on Modrinth and account for many downloads. Likely on top of that, a huge number of users who install your modpack do not understand what Sodium is or that it is significantly responsible for the performance improvement in your modpack. It seems vastly unfair that you should disable our single (non intrusive) message asking for users to donate to our development effort.

Additional details

No response

Madis0 commented 1 year ago

Yes, this was done deliberately and not out of malice.

The main reason is confusion - who do the donations go to?

So... if you can clarify that with the button and the page wording, we can talk this through, no problem.

Semi-relevant rant regarding votes and my perspective For other 45 people in this thread, who may think I'm a hater or that I'm taking money away from someone, here are some facts: * [Fabulously Optimized was created _because of_ Sodium](https://ftb.fandom.com/wiki/Fabulously_Optimized), to popularize it for the mainstream users. I'd say it has succeeded that goal. * I have contributed to Sodium [with money](https://ko-fi.com/jellysquid_), [with PRs](https://github.com/CaffeineMC/sodium-fabric/pulls?q=is%3Apr+author%3AMadis0+is%3Aclosed) and [other volunteer work](https://github.com/Madis0/sodium-fabric-translations). I do that for most other mods as well. * I encourage people to choose launchers [that support the modpack and mods](https://github.com/Fabulously-Optimized/fabulously-optimized#downloads). Admittedly, that became more difficult for Sodium since the leaving of CurseForge, but Modrinth App should arrive soon as well. * [I do not take donations for the modpack itself](https://github.com/Fabulously-Optimized/fabulously-optimized/blob/main/CONTRIBUTING.md). Previously, I suggested users to ["donate to the mods"](https://github.com/Fabulously-Optimized/fabulously-optimized/blob/cdf9916ec089171932971ac8ca4313dabbe05eaa/CONTRIBUTING.md) but for an ever-changing list of mods and unequal amount of donate vs no donate links, I realized that this is biased towards mods that have donation links, despite there also being ways to volunteer (in some way) for others too.
FlashyReese commented 1 year ago

Sodium Extra/Reese's Sodium Options (because that notably changes the video settings view as well)

Just to provide clarity, my mods have never modified the link; the button has merely been relocated for UI enhancements. You can observe the changes here.

Madis0 commented 1 year ago

Here are the issues for resolving my concern:

intergrav commented 1 year ago

The main reason is confusion - who do the donations go to?

I've had the donation button enabled in my modpacks for a very long time but this issue seems to have never popped up once in my support forum or issue tracker. Granted, FO is far more popular than my stuff but I still personally don't see the issue

FlashyReese commented 1 year ago

The main reason is confusion - who do the donations go to?

I've had the donation button enabled in my modpacks for a very long time but this issue seems to have never popped up once in my support forum or issue tracker. Granted, FO is far more popular than my stuff but I still personally don't see the issue

I believe they are attempting to raise a distinct concern regarding the ambiguity of the donation button. Not all modpack users may be familiar with Sodium or realize that their donation is directed towards a specific mod. For instance, someone might intend to support all the mods.

Kichura commented 11 months ago

Restored.

Madis0 commented 11 months ago

As Fabulously Optimized has transparency as one of its goals, and because I can still see some misinformation and misunderstandings regarding this topic, I'd like to publicly address this with a detailed FAQ:

When did Fabulously Optimized disable this button?

July 1, 2021 with Fabulously Optimized version 2.0.0b4, and Sodium (back then - Iris with Sodium) version 0.2.0. It has simply been ported forward since.

Why did Fabulously Optimized disable this button?

Because it was unclear, who the donations went to, as described in the second comment.

Why did FO just not rename it?

At the time this change was made, Sodium had all strings hardcoded, so it would've been impossible. Admittedly, that changed in only 15 days later, but at the time I was not aware of that change either.

Either way, FO did not contain any bundled resource packs until after two months.

Why did FO not discuss the issue with Sodium at the time? Why did FO not rename it later?

Because it was not seen as an issue until now.

Most mods do not have such donation buttons, so users who want to donate to them would need to refer to their listing pages anyway, and FO has Mod Menu for that.

After the issue was brought up, why did FO not change it immediately?

As mentioned in the second comment, the original issue still remains to this day, and is not exclusive to this modpack.

Nonetheless, I discussed the issue with JellySquid and proposed fixes: one simpler fix that could be done right now in upstream (but has not been agreed upon yet) and one that Jelly agreed upon, but is a bigger change and takes more time to implement.

What is the status of this in FO now?

As of FO 5.3.0-beta.3/Sodium 0.5.2, users can see the donation links in Mod Menu.

However, this issue specifically has still been lingering, so to resolve it, I've now decided to work around it on the FO side. The donation button has been re-enabled in 5.2.8/5.3.0-beta.6 and the text has been changed to "Support Sodium!", a phrasing that was favored by 4 Sodium users at the time.

What's FO's stance on donation-related features overall?

Donation buttons contained in individual mod settings are okay. In Sodium's case the "mod settings" is just the video settings page and as such, the wording should be very clear on who gets the donation.

However, other kinds of donation features like colored names, "glow", capes etc for specific mods that were not created for providing cosmetics are considered unwanted and will be disabled in FO. As of 5.2.8/5.3.0-beta.6, no mods in FO provide such features.

Madis0 commented 6 months ago

As of Sodium 0.5.6/0.5.7, it is no longer possible to independently and reliably toggle this button, so as of Fabulously Optimized 5.8.0-beta.7, it has been disabled, with the following (temporary?) workaround applied:

pilt

Unfortunately, the workaround is not clickable, hence the full URL is displayed. To resolve this, an issue has been made on Sodium's repo: https://github.com/CaffeineMC/sodium-fabric/issues/2293

Madis0 commented 6 months ago

As of 5.8.0-beta.8, the workaround has been reverted, the button and the prompt have been re-enabled.