Fabulously-Optimized / fabulously-optimized

A simple Minecraft modpack focusing on performance and graphics enhancements.
https://download.fo
BSD 3-Clause "New" or "Revised" License
877 stars 84 forks source link

ServerPingerFixer #801

Open leumasme opened 5 months ago

leumasme commented 5 months ago

CurseForge link

- (unknown)

CurseForge Mod Distribution

Unknown

Modrinth link

https://modrinth.com/mod/serverpingerfixer

Source/other link

https://github.com/JustAlittleWolf/ServerPingerFixer

Mod file size

6.98 KB

License

(any other license)

What it does

Improve multiplayer menu server pinging by increasing the max pinging threads and clearning the pinging threadpool when refresh is clicked again.
Slightly accelerates pinging + fixes the ages-old vanilla bug of all server pings failing if you spam-click refresh (which also still exists in FO)

Why should it be in the modpack

Why shouldn't it be in the modpack

Additional details

No response

Madis0 commented 5 months ago

Bug or not, if this isn't in vanilla, then servers may not expect it and cause negative effects, just like you said

some servers block/rate-limit pings when spamming refresh anyway, so they still time out

plus not marked as 1.20.4-compatible

makindotcc commented 5 months ago

Bug or not, if this isn't in vanilla, then servers may not expect it and cause negative effects, just like you said

Negative effects:

You can refresh spam server in vanilla Minecraft if servers in your serverlist are responding quickly enough. It is hard to take down server by DDoSing it with server motd packet request, so ~10 refreshes per second will not affect server performance in any way.