Fabulously-Optimized / fabulously-optimized

A simple Minecraft modpack focusing on performance and graphics enhancements.
https://download.fo
BSD 3-Clause "New" or "Revised" License
877 stars 84 forks source link

Update `README.md` #813

Closed its-miroma closed 3 months ago

its-miroma commented 4 months ago

I'm creating a new PR to fix the problems with the linter from #812.

Preview at https://github.com/its-miroma/fo/tree/readme

its-miroma commented 3 months ago

I added the badges, using shields.io, but to add custom icons I had to embed a data URI, which is a little ugly in the source code.

I used the flat style, but if you prefer, shields.io also supports the for-the-badge style.

There's also a problem with the Discord badge, because the server widget is not enabled in the FO server.

I also re-added the MultiMC download links.

Madis0 commented 3 months ago

Is there a distinct icon for light/dark mode?

No.

Update DEVELOPER-README.md Perhaps move to CONTRIBUTING.md?

Maybe... Right now the contributing page highlights things that can be done by most users, while developer-readme is for specifically those who fork FO. Therefore I am not sure those should be mixed, as the target audiences are different.

its-miroma commented 3 months ago

I forgot to ask: title, icon and badges can be centered in the page, so which style do you prefer:

Madis0 commented 3 months ago

I forgot to ask: title, icon and badges can be centered in the page, so which style do you prefer:

* https://github.com/its-miroma/fo/tree/readme (current)

* https://github.com/its-miroma/fo/tree/readme-alt (centered)

I prefer the centered one.