Fabulously-Optimized / fabulously-optimized

A simple Minecraft modpack focusing on performance and graphics enhancements.
https://download.fo
BSD 3-Clause "New" or "Revised" License
947 stars 85 forks source link

AdvancementsScreenOptimizer #885

Open Zintux opened 1 month ago

Zintux commented 1 month ago

CurseForge link

https://www.curseforge.com/minecraft/mc-mods/advancementsscreenoptimizer

CurseForge Mod Distribution

Allowed

Modrinth link

https://modrinth.com/mod/advancementsscreenoptimizer

Source/other link

https://github.com/JustAlittleWolf/AdvancementsScreenOptimizer

Mod file size

13.83 KB

License

(any other license)

What it does

Author's description Optimizes how the advancements screen is rendered Minecraft has to render a lot of textures when drawing the advancements screen. These include

the background the icons the lines

For each one it draws all the textures individually, requiring communication with the GPU each time.

The mod improves performance by batching most draw calls, so only a single one is made. Furthermore, it avoids drawing textures which are outside the advancements screen.

Why should it be in the modpack

Boosts advancements screen performance up to 200%-800% Tested on Ryzen 5500, GTX 1660 Super, 16GB Allocated RAM. Fabulously Optimized 6.1.0-beta.5 for 1.21.1 with default settings in void world 2024-09-17_14 14 20

Fabulously Optimized + Vanilla Advancements

Without AdvancementScreen Optimizer: 89 fps With: 120 fps (1.3x boost) 2024-09-17_14 14 58 2024-09-17_14 22 05

Fabulously Optimized + BlazeandCaves Advancements Pack

Without ASO: 48 fps With: 97 fps (2.0x boost) 2024-09-17_14 16 58 2024-09-17_14 20 36

Fabulously Optimized but with AdvancementInfo instead of Paginated Advancements

Vanilla Advancements Without ASO: 108 fps With: 702 fps (6.5x boost) 2024-09-17_15 56 58 2024-09-17_14 29 54

BlazeandCaves Advancements Without ASO: 53 fps With: 423 fps (8.0x boost) 2024-09-17_15 55 47 2024-09-17_14 32 09

Why shouldn't it be in the modpack

Might be incompatible with some mods that modify the advancements screen Removes lines between advancements

Additional details

No response

TheBossMagnus commented 1 month ago

Do we really need 800 fps on the advancement screen?

Zintux commented 1 month ago

Do we really need 800 fps on the advancement screen?

Is there something bad in free optimization? With this mod we can either get fps closer to our refresh rate and make this screen feel not that sluggish or reduce gpu utilization if fps arleady reaches monitor refresh rate Test with advancementinfo was only for comparison, it's just strange that this mod reaches its full potential only with advancementinfo or advancementsfullscreen (and doesn't remove lines with these 2)

TheBossMagnus commented 1 month ago

Is there something bad in free optimization? With this mod we can either get fps closer to our refresh rate and make this screen feel not that sluggish or reduce gpu utilization if fps arleady reaches monitor refresh rate Test with advancementinfo was only for comparison, it's just strange that this mod reaches its full potential only with advancementinfo or advancementsfullscreen (and doesn't remove lines with these 2)

Free optimizations would be fantastic if they were available. But this isn't free. Why? It implies adding a mod, and doing so —with any mod— might not be as beneficial as it seems

Incompatibilities: Adding a mod increases the risk of conflicts with other mods, leading to a higher volume of bug reports and troubleshooting.

Additional File: Each mod adds another file, resulting in a slightly larger download size and longer load times.

Maintenance: The most significant issue is the ongoing maintenance. Keeping up with updates for newer Minecraft versions, ensuring compatibility, and managing any bugs can be time-consuming.

In my opinion, the benefits of this particular mod don’t outweigh the potential drawbacks. While it may offer some improvements, it may not provide enough enhancement to justify the extra hassle. Of course, everyone is free to use it if they want.

Madis0 commented 1 month ago

If this mod is beneficial with those other mods you mentioned, maybe it can be implemented inside them...