search

Fabulously-Optimized / installer

MIT License
3 stars 1 forks source link

Folder path selector #3

Closed Madis0 closed 1 year ago

Madis0 commented 1 year ago

Not everyone may have the game in the default folder

vgskye commented 1 year ago

so, I cannot find an option in the Minecraft launcher to change the storage folder?

Madis0 commented 1 year ago

"Game directory" in the individual installation settings image

vgskye commented 1 year ago

ah, that? how should it interact with the profile isolation option?

Madis0 commented 1 year ago

Perhaps the profiles could be inside that folder? So something like ~/.minecraft/FOversions/4.10.4

vgskye commented 1 year ago

what

Madis0 commented 1 year ago

Minecraft usually stores its instance files on .minecraft.

The default assumption is that this folder exists on %appdata%\.minecraft or ~/Library/Application Support/minecraft or ~/.minecraft, but it may not always be the case (e.g. external drive). So, just like the launcher itself, and installers like Fabric's, this installer should have an option to let the user change its path.

Once changed, the folder should be used for both isolated and non-isolated installations of FO, where isolated should be a subfolder and non-isolated the folder itself.

vgskye commented 1 year ago

sorry for not doing anything for a while; was busy with other stuff I still can't find the option to change the instance folder on the launcher; the screenshot you sent only applies to the individual profile

Madis0 commented 1 year ago

I still can't find the option to change the instance folder on the launcher; the screenshot you sent only applies to the individual profile

Yes, but there is no need for that option in the launcher. Just keep the path stored in a config file (or similar) for the installer and use that path for every instance installed to the launcher. Or, more accurately, every new instance, there is no need to change older instances if the installer path changes.

vgskye commented 1 year ago

so, an option to have the profile folder in a place other than .minecraft or .minecraft/fabulously-optimized-${mc_version}?

Madis0 commented 1 year ago

One folder path option for ~/.minecraft part and one checkbox to choose whether to have subfolders by instance or use just the root of the .minecraft path.

vgskye commented 1 year ago

github apparently doesn't like me trying to close two issues with one commit