search

Fabulously-Optimized / vanilla-installer-python

An installer for adding an Fabulously Optimized installation to Minecraft Launcher
MIT License
13 stars 6 forks source link

[Feature Request]: Accessibility #27

Open nsde opened 2 years ago

nsde commented 2 years ago

Potential Enhancement

TODO:

How it could be implemented

Settings in menu

Anything else?

No response

osfanbuff63 commented 2 years ago

It's something to have at some point for sure, but the way the GUI looks right now isn't ideal. I tried playing around with it, but nothing actually seemed to work. As I put in docs/planned-features.md I'm wanting to rewrite it at some point, but the current priority is getting a working release.

Madis0 commented 2 years ago

Does any of this actually need settings? Can't you just ping the system for this?

osfanbuff63 commented 2 years ago

Good point - but #31 already implements a settings menu, so in theory it would be easy to add more options to it.

Madis0 commented 2 years ago

One does not exclude the other 😄 Where possible, these things should be taken from the system. Where not - an option is fine.

osfanbuff63 commented 2 years ago

Or both :P

osfanbuff63 commented 2 years ago

Updates updates updates...

I can't seem to find a way to detect the font set in the OS, but there's even an official class for fonts, so that could be of use.

osfanbuff63 commented 2 years ago

More updates - decided to implement 1) with a checkbox or similar in the existing settings menu so that I don't need to make a new dialog (although I might do that down the line), 2) doesn't seem like it would be easy to implement, and the OS/monitor should apply it automatically, and I haven't looked into 3) yet.

osfanbuff63 commented 1 year ago

Because of 1.19.3's release, I'm going to push this back from the v1.0.0 beta release since it's not really needed to get a version out. (Since that beta release is coming very soon 👀).

osfanbuff63 commented 1 year ago

aaah forgot this issue had other things on it

Kichura commented 1 year ago

We could implement a similar high contrast theme mode as the one from 1.19.4's resource pack itself although i don't personally know how well that would look.

nsde commented 1 year ago

Basically bg-color black and fg-color white, I guess?

Kichura commented 1 year ago

morely black because that's what minecraft uses.