Fabulously-Optimized / vanilla-installer-python

An installer for adding an Fabulously Optimized installation to Minecraft Launcher
MIT License
13 stars 6 forks source link

[Feature Request]: Warn on downgrades #80

Open Madis0 opened 1 year ago

Madis0 commented 1 year ago

Code of Conduct

Potential Enhancement

Vanilla installer should show a big scary warning when attempting to downgrade an instance.

Edit: when mods, config and saves folders are empty or missing, skip this warning.

How it could be implemented

Check if currently installed Minecraft version is newer than the one user wants to install. If yes, show a popup with text, like

You are attempting to downgrade the Minecraft version. This is NOT SUPPORTED by Mojang or Fabulously Optimized and it may cause world corruption or crashes. If you want to do this safely, you should backup mods, config and saves folders to a different location and delete them from your .minecraft folder. ` I agree that downgrades are unsupported by Mojang and Fabulously Optimized, but I want to do this anyway. Open .minecraft`Install anyway*

* button is enabled only when the checkbox is checked

Anything else?

Even something as simple as 1.19.2 -> 1.18.2 currently causes a Zoomify crash, so this is definitely needed.

osfanbuff63 commented 1 year ago

Should we extend this to stable -> alpha/beta versions of FO as well? Or just downgrading, as that would cause more of a problem?

Madis0 commented 1 year ago

Good point, that requires a special message too. How about

You are attempting to install an experimental version of Fabulously Optimized. While it is supported, it is currently incomplete and some features may be missing. You may also experience crashes or bugs, please report them to our Discord. If you want to do this safely, you should backup mods, config and saves folders to a different location and delete them from your .minecraft folder. ` I am willing to install this experimental version Open .minecraft`Install anyway*

* button is enabled only when the checkbox is checked

Madis0 commented 1 year ago

Might as well mention that this warning is not needed if the user is using separate instances for FO versions (#61).