search

FaceDeer / dfcaverns

Replicating Dwarf Fortress' underground flora in Minetest
Other
16 stars 9 forks source link

Fix dependency on simplecrafting_lib #34

Open rubenwardy opened 1 year ago

FaceDeer commented 1 year ago

Hi, sorry I kind of left this pull request in limbo for a bit. As you can see from the mineclone_compatibility branch I've been kind of busy. :)

I think this actually isn't correct, though. The goal of simplecrafting_lib was to provide a library that other mods could use to create variants of a shapeless-based crafting system off of. crafting was one such mod, but others might not have a "furnace" type and so might want to do things differently.

I've been on a rather lengthy modding hiatus and have forgotten a lot of what I did with simplecrafting_lib and crafting, though. Once I've finished this massive mineclone project (there's a couple other mods I'm also porting over) I'll take another look through it all and see whether I'm remembering correctly.

rubenwardy commented 1 year ago

Just thought I'd explain where this is coming from: the crafting name is contested, multiple mods used that name before ContentDB started requiring mods to use unique mod names.

The first use of the crafting mod for was a Minecraft-like inventory, I can't find any current uses of this on ContentDB or servers. Exile, CTF, and Water Game all include my Unlockable Crafting mod. Only dfcaverns depends on your crafting mods and no games include it on ContentDB.

If someone tries to enable dfcaverns mod whilst either of the other mods are installed, it will crash Minetest. Given that you use the simplecrafting_lib API, depending on it seemed like the best idea. Also, even if there were no other crafting mods - it would still cause issues if the original "easy crafting table" is installed

Summary

Instances

  1. BlockMen's MC-like crafting
    • Largely abandoned, minimal API.
    • Forked here not updated since posting
  2. Second use was easy crafting table: https://forum.minetest.net/viewtopic.php?t=15405
  3. rubenwardy's crafting mod: https://forum.minetest.net/viewtopic.php?t=19908
  4. Facedeer's fork of easy crafting table using simplecrafting_lib: https://github.com/FaceDeer/crafting/

All these predate right to a name.

In use today

Version CDB Number of games CDB Number of dependers Servers
MC-like crafting 0 0 0
Easy Crafting Table 0 0 0
rubenwardy's crafting 3 (CTF, Exile, Water Game) 0 7 (6 ctf, 1 exile)
FaceDeer's unpublished ECT fork 0 2 (DF Caverns) 0