search

FaceTheFacts / web

Face the Facts Web Application
Other
22 stars 2 forks source link

[Bug] Area: Voting Cards are shown for votes politicians don't take part in #127

Closed Fingolf6455 closed 3 years ago

Fingolf6455 commented 3 years ago

Describe the bug When the politician is a member of the German parliament but abstained the vote the vote still shows up on the profile.

To Reproduce Steps to reproduce the behavior:

  1. Go to Beta.facethefacts.app
  2. Click on 'Zur Demo'
  3. Search for "Markus Söder"
  4. See error

Expected behavior

  1. The card of the vote is not displayed if the politician was not abstained at the vote.

  2. If he is not at all a member of the parliament show the following message for the whole "Profilseite": "Diese:r Politiker:in ist nicht Teil eines Parlaments, deshalb gibt es hier nicht viele Informationen über ihn."

Screenshot

WhatsApp Image 2021-06-10 at 11 53 37

Additional context If you have questions about the second part hit me up.

Fingolf6455 commented 3 years ago

Richard already solved the bug but didn't push it :D