Button improvements - Githubissues

DezLife commented 4 months ago

Added functionality for opening external links in the UI and implemented URL checks

Implemented the ability to open external URLs in the user interface via buttons.
- This allows users to directly interact with and access external resources from within the application interface.
Added a check for URLs to ensure only links starting with http:// or https:// are opened.
- This security measure prevents the potential opening of local files from the UI, enhancing the safety of the application.
Applied new styles to buttons, including color settings for different states (normal, highlighted, pressed) and smooth color transition.
- Enhances user experience by providing visual feedback through color changes, reflecting the button's state.
Compatibility assurance with existing UI components.
- These enhancements have been designed and tested to ensure that they integrate seamlessly without disrupting the existing UI components, maintaining the integrity and performance of the existing user interface.

[!WARNING] I also suggest adding a confirmation dialog before navigating to external websites and a notification about the possibility that it might be a phishing site. These precautionary measures will provide additional protection to users and alert them to potential risks when navigating to external links. Similar warnings can also be implemented for the URL (server.url) button in the server window to ensure the security of using this feature.

the JSON representation

{
  "type":"UnityEngine.UI.Button",
  "url":"https://facepunch.com/",
  "normalColor": "1.0 1.0 1.0 1.0",
  "highlightColor": "1.0 1.0 1.0 1.0",
  "pressedColor": "0.78 0.78 0.78 1",
  "fadeDuration": 0.1,
},

Importance of These Innovations

Filling a Critical Need
- The addition of external link capabilities directly addresses a significant gap in our UI that has been noted by both users and developers who create plugins. Providing a mechanism for safely opening external URLs from within the game's UI was a highly requested feature that enhances the utility and user experience.

Testing and Validation

Updated Test UI
- A test UI has been updated to include and showcase the new changes, allowing for thorough testing and review before final integration.
- This updated test environment is essential for verifying the functionality and usability of the new features, ensuring they meet our standards and user expectations before they are deployed to production.

Thanks @Kulltero for your help

DezLife commented 4 months ago

@ElChupos

I kindly ask you to pay attention to this and give some kind of answer. It's really scary that for the most part it's abandoned. A lot of people are trying to contribute to this.

This is really useful functionality. The developer has to force users to copy the link from Input and then go to the browser. I don't think it will take much of your time to consider this.

Mercury-devs commented 4 months ago

Oh, yes! I fully support this idea, it is a simple and extremely necessary solution for servers, administrators will thank you very much for this!

I hope this will appear in the near future!

VooDooC commented 4 months ago

Its a good idea, i think it should have been done a long time ago

ninco90 commented 4 months ago

Please implement this. It will be great to take users to our Discord, statistics page, rules page, donation store, tutorials, social networks... And not have to pass the URLs through notes.

To add some security and prevent very long urls from being entered with certain content in base64 or similar, I would recommend limiting the maximum number of characters that can be used in the url. Maybe 150 characters.

TurEduard commented 4 months ago

@DezLife, @ninco90, @VooDooC, @Mercury-devs. Friends. For the developers to hear us and add this to the game, we need to draw more attention to this issue. Need more comments and likes. Let's invite friends, acquaintances, players who also support this idea and vote or comment on this pull

DezLife commented 4 months ago

You could use a dialog box like the one in my screenshot to confirm the link. @ElChupos @Jake-Rich