Facepunch / garrysmod-issues

Garry's Mod issue tracker
141 stars 56 forks source link

Icons clip through tree view border #2708

Open oldmud0 opened 8 years ago

oldmud0 commented 8 years ago

Picture explains everything: eb67e394-4516-11e6-918e-44aaac257f7d 1 Near the "Update" button, the icons seem to overlap the border of the control.

Reported at wiremod/wire#177, but Divran (Wiremod dev) has concluded to "blame Garry" since they are using a non-custom DTree element.

robotboy655 commented 8 years ago

Sadly this cannot be easily & properly fixed. They can fix it though for their specific case, since they seem to override the background to one without dark borders like the default control has.

oldmud0 commented 8 years ago

Why is the solution difficult? Please enlighten me.

robotboy655 commented 8 years ago

There are 2 solutions: 1) Set render bounds for children 1 px less - requires this functionality to be implemented + will fuck up the scrollbar 2) Use a separate internal panel that will have 1px margin - will break mods that use DScrollPanel methods on this panel directly

oldmud0 commented 7 years ago

Issue aged away (wontfix).

Kefta commented 7 years ago

There are plenty of old issues on here. Don't close issues that aren't fixed.

oldmud0 commented 7 years ago

I assure you that no one cares enough to fix it.

Kefta commented 7 years ago

Then I guess pages 2-23 should be closed too, right?

oldmud0 commented 7 years ago

Sure. I mean, whoever is currently working on GMod is unlikely to ever take something from the bottom of the pile, and there's very little non-developers can do, so it's just clutter.

Kefta commented 7 years ago

They're actual documented issues. Closing them does a disservice to people having the same issue and can't find out if the issue lies with their specific game/code or globally.

oldmud0 commented 7 years ago

Closing an issue does not invalidate it. If anyone ever expresses a vested interest in having this particular issue fixed, I will reopen it. But since it appears that I have been the only one who has wanted a dev to work on the issue, and now even I am not interested in a fix anymore, it's pointless to keep it in the queue.

Kefta commented 7 years ago

But it's not a queue, it's a tracker.

oldmud0 commented 7 years ago

If you are so concerned about keeping this open, fine.