Crash: Subscribing to Workshop Addons with Fonts while in a server

[WinterPhoenix]

Details

Happens while Workshop Addons are being extracted while the client is in a server that's using those addons. Maybe has to do with extracting Fonts as that's the last thing that happened before it crashed.

Crash Dump: https://winteris.moe/share/2019-04-05_14-10-02.mdmp

Steps to reproduce

This seems to reliably reproduce the issue on GMod Cruise Line:

1. Switch to the Main Branch
2. Unsubscribe from all GMod Cruise Line addons
3. Remove any GMod Cruise Line content from:

   GarrysMod/garrysmod/addons
   GarrysMod/garrysmod/cache/workshop
   GarrysMod/garrysmod/cache/workshop/resource/fonts
   GarrysMod/garrysmod/download
   GarrysMod/garrysmod/downloads/server

4. Join the server: https://www.gmodcruiseline.com/connect.html
5. Subscribe to all addons in the Server Content Collection: https://steamcommunity.com/sharedfiles/filedetails/?id=879194672
6. Sometime during Extraction, the client should crash

[robotboy655]

Has nothing to do with fonts, it crashes when playing sounds.

You should not be subscribing to addons while in-game.

[WinterPhoenix]

Is there any sort of mitigation for the crash that you'd suggest other than simply not subscribing to things while in-game? Maybe preventing sounds from being played from Lua?

[thegrb93]

You should not be subscribing to addons while in-game.

Tell that to pac3 and outfitter

[Kefta]

Tell that to every server that downloads addons to clients while in game.

[thegrb93]

Hotloading is really popular

[robotboy655]

I think this was the same issue as #5775, but I also encountered another crash relating to static props when joining your server with downloads blocked, so that one should also be fixed now.