search

Facepunch / garrysmod-issues

Garry's Mod issue tracker
147 stars 56 forks source link

Named Lights won't show up in CSGO Maps #4028

Open Matty-64 opened 5 years ago

Matty-64 commented 5 years ago

Despite CSGO supporting Light Styles and Named Lights, Lights like that won't show up in Garry's Mod at all for CSGO maps.

CSGO: csgo_lightstyle_bug_test0000

GarrysMod: csgo_lightstyle_bug_test0001

The map above was compiled using CSGO's compile tools, in it, the light to the right is named and has a light style applied to it, it shows up in CSGO, but not Garry's Mod.

This was tested in the Main, Dev, and x64-86 branches without addons, all have the same issue.

Steps to reproduce

  1. Download this map: csgo_lightstyle_bug_test.zip
  2. Play the map in GarrysMod, and the named light to the right won't show up; Play the map in CSGO, and the light will show up.
robotboy655 commented 5 years ago

I would say the actual problem is probably your Appearance setting, which is probably different in CS:GO compared to GMod. image

Matty-64 commented 5 years ago

Like, compared to CSGO and Gmod, they have different values for Appearance? I looked in both games' FGDs, they seem to have the same values:

fgd_comparison

I just tried using "Normal" appearance, it still happens while the light is named. I even tried various other things: Various compile settings like -final, -hdr, -aoscale, -StaticPropLighting, etc.
All Appearance settings, even the unused 12 setting. The Custom Appearance setting with a value of 'azaz'. Setting the "Initially Dark" spawnflag, and then turning it on with the "TurnOn" input. Changing the color of the light, along with it's brightness.

I tried all of the above with the same issue. Interestingly though, I noticed the named light will show up on models like prop_physics and prop_static, even the view model of the player gets lit, just not on any of the world brushes static or not. So the light does still exist, and it even shows the Appearance chosen on models.

Here's a updated map showing everything a named light will light up and what it won't light up. csgo_lightstyle_bug_test.zip

robotboy655 commented 5 years ago

Yeah you are right, unfortunately I don't know why this is.

Matty-64 commented 5 years ago

Well, if it helps any, the only other thing I've been able to find out from my tests, is builds of CSGO before the May 12th, 2017 update, which was the update Valve started pushing fixes for CSGO's lightstyle issues with CSM. Maps compiled with the tools before that build of CSGO will, for some reason, show light styles in the map for Gmod! I compiled a map using the compile tools from CSGO's May 4th, 2017 build, and lightstyles actually showed up in my bug test map.

I guess Valve might of changed how lightstyle lightmaps are saved for brushes in the BSP or something.