Facepunch / garrysmod-issues

Garry's Mod issue tracker
147 stars 56 forks source link

Context menu exposes players with GetNoDraw set to true #4760

Closed mcNuggets1 closed 3 years ago

mcNuggets1 commented 3 years ago

Details

If you hover over a player, it adds an halo around the player's body, even if SetNoDraw(true) is set to true to them. This can be used to easily identify invisible admins for example.

Steps to reproduce

Hover over something, that is NoDraw and see it being outlined.

thegrb93 commented 3 years ago

Also this would be good. https://github.com/Facepunch/garrysmod/pull/1751

thegrb93 commented 3 years ago

Something to make prop_effect ring fully invisible too pls. Properties menu option would be great.

mcNuggets1 commented 3 years ago

Yeah, but the most important is, that you actually cant expose admins lol

robotboy655 commented 3 years ago

Something to make prop_effect ring fully invisible too pls. Properties menu option would be great.

There should be an option for this in C > Menubar on top > Drawing and in the Q > Utilities > Sandbox Settings

thegrb93 commented 3 years ago

Something to make prop_effect ring fully invisible too pls. Properties menu option would be great.

There should be an option for this in C > Menubar on top > Drawing and in the Q > Utilities > Sandbox Settings

You have to tell other people to do that. I would prefer if everyone could just see my work without the rings and without having to be told to do that.

thegrb93 commented 3 years ago

I'll add that and a new dupe parameter for it in a bit.

mcNuggets1 commented 3 years ago

People abuse it a lot to expose invisible objects, which kind of sucks right now. This is very different to the stuff, thegrb93 is pointing out.

thegrb93 commented 3 years ago

I'd say yours is higher priority, but all of it can be fixed super easily.

robotboy655 commented 3 years ago

https://github.com/Facepunch/garrysmod/commit/ae8e6145481ccc4fb39fb432d3e25c575aae7646

mcNuggets1 commented 3 years ago

Thanks rubat.

mcNuggets1 commented 3 years ago

But maybe add an IsDormant check too.

Also I hope this doesnt break any addon compatibility.