search

Facepunch / garrysmod-requests

Feature requests for Garry's Mod
84 stars 24 forks source link

Chromium (microphone) permissions #1488

Open Earu opened 4 years ago

Earu commented 4 years ago

Like in Chrome or Firefox for instance it would be useful to be allowed to request user microphone permission per page. This could extend to other permissions such as webcam or notifications for instance.

ExtReMLapin commented 4 years ago

WHAT COULD GO WRONG

On a serious note, just use a browser.

nodgear commented 4 years ago

WHAT COULD GO WRONG

On a serious note, just use a browser.

Just imagine, non shitty voice comms

ExtReMLapin commented 4 years ago

Just imagine, the fucking privacy

Kefta commented 4 years ago

GMod needs a menu state permissions systems that limits the client state, allowing users to opt-in to functionality.

thegrb93 commented 4 years ago

Nope

Kefta commented 4 years ago

Great feedback.

ExtReMLapin commented 4 years ago

it's dumb by design, we're not going to make some kind of panel "enable web mic for this server" as there is no way to know if the web page is only listenening when the player press the mic key or if it's in a spy mic mode.

Then what ? Add something on the HUD that tells if the mic is being used ?

When you have to think about hotfixes even before starting developing your project, it means it's a bad project

nodgear commented 4 years ago

Maybe not for this server, but site. And, having indicator showing ter mic os beeing used.

Chromium nas both of this features And they are not Just hotfixes, but a feature

ExtReMLapin commented 4 years ago

When what you're proposing has issues, answering to the issues by "make a menu to whitelist websites" and "add something to the hud to tell when the mic is being used", it's the quality of an intern releasing an hotfix on a game used by thousands.

yo trust me bro it works

yo trust me bro it flies

You can propose this kind of "hotfixes" when the main feature is already in place since months/years and people are used to it so you can't remove it from the game else they would go boogalo mode.

Here it's not even released and it already has issues.

thegrb93 commented 4 years ago

The real issue is this is really niche, not a part of the game, requires a lot of work to make safe.

My guess is he wants to use it to replace the in-game mic system which really does need to be updated and should be much higher priority than this.

VaasKahnGrim commented 4 years ago

TBH chrome did it quite nice with having mic and web cam usage being a permission based thing for each site. It would be quite nice if we could finally get rid of needing bullshit software such as teamspeak3 or discord in order to have voice that doesn't sound like we are in metal boxes on servers.

Earu commented 4 years ago

To answer some of the claims here, yes I had in mind to do a voice system using WebRTC. Aside of replacing the default voice system, this kind of thing could be useful for example with discord integration and whatnot. Imagine being able to link your in-game voice chat to the associated discord voice chat. Sounds pretty cool to me.

Now I also agree that the proper solution at least for the original idea I had would be to improve the existing voice chat and yes it should be put at a higher priority than this. Nonetheless I still would like to have this feature it'll definitely enable developers to do a lot of cool stuff with it.

I'm sure something can be done with the menu state, I'm not big on security, but if you have something similar to what gui.OpenURL does whats the big issue?

VaasKahnGrim commented 4 years ago

having it function as an optional voice connection would be nice. like if players did open the connection, all voice data gets sent to a seperate online service for handling voice data.

a good use case would for example be in starwarsrp, where normally differant regiments would have their own teamspeak/discord channel to chat in with voice. but with this users could connect via the game to a voice service and then join a specific channel via a window that pops up when they made the connection.

another use case could be for using a online voice changing system, for example in Warhammer40k RP servers spacemarine players could actually have a voice that sounds like they are speaking through a vox grill on their helmet.

and both of those could be done through the game without users being required to install some additional software to do it. Being able to send data from lua along with it would be nice aswell(ofcourse nothing majorly sensetive but say we wanted to transmit the users position in the map to the voice server then we could simply send that aswell)