search

Facepunch / garrysmod-requests

Feature requests for Garry's Mod
85 stars 24 forks source link

util.Base64Encode - option to omit the newline after every 76th character #1889

Closed WilliamVenner closed 3 years ago

WilliamVenner commented 3 years ago

util.Base64Encode is compliant with RFC 2045, meaning it inserts a newline every 76th character.

I am not really sure why they did that. All I know is that is it very inconvenient in some situations, is a waste of space (util.Base64Decode doesn't require this newline anyway) and is a waste of performance as removing the newlines in Lua comes with a cost.

It would be great if there was an argument to disable this behaviour.

thegrb93 commented 3 years ago

Especially since chromium doesn't support the newlines

robotboy655 commented 3 years ago

Done.

WilliamVenner commented 3 years ago

Cheers Rubat

On Tue, 13 Jul 2021, 11:06 am Rubat, @.***> wrote:

Closed #1889 https://github.com/Facepunch/garrysmod-requests/issues/1889 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Facepunch/garrysmod-requests/issues/1889#event-5012721765, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRM27537ZGLPBPYOMFXRYLTXQFZHANCNFSM5AHIRK5Q .