Bind Missing Tags for IGModAudioChannel via BASS_ChannelGetTags - Githubissues

Facepunch / garrysmod-requests

Feature requests for Garry's Mod

84 stars 24 forks source link

Bind Missing Tags for IGModAudioChannel via BASS_ChannelGetTags #1945

Open WinterPhoenix opened 2 years ago

WinterPhoenix commented 2 years ago

Details

Currently we're missing several tag types for IGModAudioChannel that are supported by BASS. They are:

BASS_TAG_APE / BASS_TAG_APE_BINARY
BASS_TAG_CA_CODEC
BASS_TAG_ICY
BASS_TAG_ID3V2 / BASS_TAG_ID3V2_2
BASS_TAG_MF
BASS_TAG_MP4
BASS_TAG_WMA

Mainly the ones I'm looking for are ICY and ID3v2, but having all of them would be ideal.

ID3v1 doesn't support Unicode, which is how I ran across this issue. I can provide example files if need be.

https://www.un4seen.com/doc/#bass/BASS_ChannelGetTags.html

Maybe consider fixing this whenever BASS gets updated (#1885)? Thanks!

WinterPhoenix commented 2 months ago

Bumping this since I ran into yet another audio stream that I can't get tags from: http://smoothjazz.cdnstream1.com/2585_128.mp3

Here's a screenshot for why this sucks, and gives you an idea of what I'm trying to do:

I think it's ICY tags in this case, given the HTTP headers. For reference, works fine in VLC: