Facepunch / garrysmod-requests

Feature requests for Garry's Mod
83 stars 24 forks source link

Add a few file types to the file whitelist #2411

Closed marchc1 closed 1 week ago

marchc1 commented 2 weeks ago

Details

The following file types would be rather useful for me and I'm sure others:

.mid

Writing MIDI music files.

.obj

Writing basic 3D models. A real world example is https://github.com/shadowscion/Prop2Mesh, this addon has the ability to export props as a .obj, but has to save the filename as a .txt.

.gltf, .glb

Writing more advanced 3D models/scenes

.bin

The GLTF specification for .gltf uses .bin files for the geometry/animation/buffer data. It's only recommended, according to 2.6 "File Extensions and Media Types", and I'm not sure if there may be a more valid reason to keep .bin blocked. If that's the case, .dat would work fine for my use cases and the format doesnt require you to use a specific file extension.

robotboy655 commented 1 week ago

My "philosophy" in adding extensions to the whitelist is basically extremely common formats (json, etc) + whatever the game itself can actually use. (sounds, models)

These all look very niche, and the game cannot use them out of the box. I do not see a good reason to add them.