search

Facepunch / garrysmod-requests

Feature requests for Garry's Mod
83 stars 24 forks source link

Restore jit.util.funcuvname #2418

Open ryanoutcome20 opened 6 days ago

ryanoutcome20 commented 6 days ago

Details

Restore jit.util.funcuvname from being deprecated and disabled as it's broken a few of the addons that I have installed and it is functionally identical to the still functional debug.getupvalue (which is also functionally identical to the upvalues returned by debug.getinfo and jit.util.funcinfo).

robotboy655 commented 5 days ago

The wiki does say not to use it, even before it was broken, for the entire duration of it being on the wiki.

What addons exactly are broken as a result?

ryanoutcome20 commented 5 days ago

The wiki does say not to use it, even before it was broken, for the entire duration of it being on the wiki.

What addons exactly are broken as a result?

E2 Stencil Core was the one causing issues, and I'm sure there's plenty more out there. There is no reason to remove useful functions (especially those whose entire purpose and functionality still exist in other forms), although I doubt very much that you really care about backward compatibility considering how much non-dangerous utility functions were removed as a "preemptive measure". 

In the end, if you want to add the functionality back but you're worried about the big boogeyman hackers, you can just add the functionality back using direct debug.getupvalue and just adjusting the index.