Set `BRANCH` on Linux DS properly

Facepunch / garrysmod-requests

Feature requests for Garry's Mod

86 stars 24 forks source link

Set `BRANCH` on Linux DS properly #2474

Closed RaphaelIT7 closed 1 month ago

RaphaelIT7 commented 2 months ago

Details

So, if I remember correctly,
Rubat said that it uses the steamclient to get the current branch of the game.
Since a dedicated server doesn't have this steam client, the BRANCH will always be unknown.

So my suggestion is to save the branch in the garrysmod.ver and load/set it like done with VERSION and VERSIONSTR. This would solve it and hopefully shouldn't be too hard to do.

Grocel commented 1 month ago

Yeah that issue and even the reason kinda annoys me. There are obviously different code bases for each branch, so why not hardcode the branch in them? This issue exists in Windows dedicated servers too.

RaphaelIT7 commented 1 month ago

:eyes:

Grocel commented 1 month ago

Apparently Rubat changed it the latest commit.

robotboy655 commented 1 month ago

Made it fallback to garrysmod.ver when Steam isn't available, such as for SRCDS.