Facepunch / garrysmod-requests

Feature requests for Garry's Mod
86 stars 24 forks source link

Return gui.HideGameUI() to its original working form. #2495

Closed MagentaIris closed 1 month ago

MagentaIris commented 1 month ago

Great, here we go again.

Removing a function that was perfectly fine and in working form that is 5 years old.

I sometimes add extra menu items to the escape menu via DrawOverlay because there is no OFFICIAL way to add options to the escape menu for gamemodes or extra menus.

Players are now unable to click that button because the game screams that gui.HideGameUI() is now pointless and I should be using a hook to "Cancel the pause menu from opening"

Okay, Fair, but what about closing the pause menu in reaction to the user clicking an option?

Because clearly GM:OnPauseMenuShow() only triggers when the pause menu is being opened.

Simply just adding GM:OnPauseMenuShow() without messing up gui.HideGameUI() would have been perfect, Yet here we are with absolutely no reason for nuking the other method.

If you're going to tell me that gui.HideGameUI() can be "Used maliciously to stop people's menus from being opened" then for the love of god please understand that half of the damn coding language can be "Maliciously used" to mess with people, this should not be your reason for destroying creativity.

Just add the same Hold Shift bypass to gui.HideGameUI() that GM:OnPauseMenuShow() has, if people are being messed with they can just hold Shift, click escape, click disconnect.

Image

MagentaIris commented 1 month ago

I'm assuming "Completed" means that it will be returned to its former function?

I'm asking so my assumptions can be corrected.