search

Facepunch / garrysmod-requests

Feature requests for Garry's Mod
84 stars 24 forks source link

Raise the voice chat quality #479

Closed Leystryku closed 4 years ago

Leystryku commented 9 years ago

Hello, May you please change the voice sample rate from 11025 to 32000 ( #define VOICE_OUTPUT_SAMPLE_RATE 11025 // Sample rate that we feed to the mixer. | engine/audio/public/voice.h ) and default sv_use_steam_voice to 0?

By raising the voice sample rate from 11025 to 32000 the quality becomes decent. 11025 is the ~current quality and it sounds really bad, 22050 sounds better but is still "metallic", 32000 sounds good and 44100/48000 sounds nice, however, since it's voice chat the best is to do a compromise between quality and data size so 32000 would be perfect. Thanks.

UltimateByte commented 4 years ago

@Kefta Sorry for the length of that comment, but there are some things that need a detailed answer to demonstrate a point.

It is true that I was following from a distance on a forum back then, so I'm mainly talking about what I'm seing now. The past doesn't really matter to evaluate the quality of support here and now.

For communication now... Well, there are changelogs. But from what I've seen before and today on this Git, #647 #479 #1452 #511 , you're pretty much the most active @Kefta and I'm not even sure you're part of the staff... Main devs that I know of remain silent. Nobody is even sorting issues or adding tags. I mean, did anybody even try to find out how Github works to find benefits to using it compared to a simple forum? Instead, I only see ignored posts, closed issues and free distasteful comments from time to times.

I mean, take this specific issue for example. The only dev comment says "Stop with the "+1" spam, it is not helping anyone." Nice. Very nice. As the amount of dislikes on this comment demonstrates: Not only is this lacking politeness, it doesn't provide any information regarding the actual issue, any consideration for users, it's just as unprofessional as it can get. That's the kind of things you might say as an independent giving his time for free, but not as a company member (and I sincerely hope they are). There's nothing to be proud of with this kind of behavior and I myself had remorse when answering badly to comments on a git I was volunteer on... And it shall be worst, unacceptable as an employee in a company with proper management.

For having been a very active dev for LinuxGSM project during a few years back in 2014-2017, I can tell that this free & open source project primarily managed by one single man is maintained way more cleanly and efficiently than Facepunch's one. To give you an idea: https://github.com/GameServerManagers/LinuxGSM/issues Just look at tags, at issues opened by the creator himself, and the amount of answers by people who actually try to solve issues there. That is organized. This Facepunch git is not, it's a real mess, a trash can.

If one man can do so well (even though not perfect but still) for a free project, how can a company managing a project for 10M paid users struggle so much to do things decently? I can only think of one thing: poor management. #Facepunch

thegrb93 commented 4 years ago

They don't use github for task management. This is just a public tracker for community members to report things.

UltimateByte commented 4 years ago

They don't use github for task management. This is just a public tracker for community members to report things.

Then why use Github rather than a stupid forum? Don't act like an Apple fanboy justifying every single mistake they make. Making public tool for bug reporting implies showing some respect to people participating and keeping it at least somewhat organized.

thegrb93 commented 4 years ago

That's your opinion. Judging from the last few changelogs, it's been working out quite well.

thegrb93 commented 4 years ago

@robotboy655 lock this thread already

ExtReMLapin commented 4 years ago

I think it would be wiser to ban the guy from FP repos as he's not contributing at all.

JShorthouse commented 4 years ago

This whole discussion is stupid, but @UltimateByte isn't saying anything wrong.

Just lmao at all the kids in here coming out to provide free defence for a multi-million dollar game studio. Remember who is paying who.

thegrb93 commented 4 years ago

It's not wrong or right, it's opinion. We're as free to disagree with him as he is to give his opinion. Calling people kids is just as toxic as his shit attitude.

UltimateByte commented 4 years ago

What's the problem with opinions as long as they are argumented?

thegrb93 commented 4 years ago

There isn't, it's the condescending rhetoric and insults that are the problem.

Kefta commented 4 years ago

Please move this discussion to the GMod discord or anywhere else but this repo. This is an issue tracker and watchers are notified for every comment left.

I apologise for contributing to the spam, I didn't expect it to continue.

Leystryku commented 4 years ago

For the love of christ, may you both please stop posting here? My mailbox keeps getting flooded by all the notifications.

Both sides have some valid points. Yes it could've been done quicker but also yes it's a big game with only 2 developers actively working on it so it's not that easy to take care of everything.

Either way, arguing here solves nothing.

JShorthouse commented 4 years ago

with only 2 developers actively working on it

Which is entirely the fault of facepunch, and not an excuse. May I remind you that this game has probably made ~$50M gross, we're not talking about some niche indie studio that can't afford staff.

thegrb93 commented 4 years ago

They are free to do with that money what they want, and for most of their studio, that is develop other games. If you want to apply as a Garry's Mod dev, prove your worth and apply for it.

Developers don't grow on trees.

UltimateByte commented 4 years ago

They are free to do with that money what they want, and for most of their studio, that is develop other games. If you want to apply as a Garry's Mod dev, prove your worth and apply for it.

Developers don't grow on trees.

We are also free to criticize. Without criticizing, no evolution, no improvements. Shouting on Discord won't improve anything either. People are free to unsubscribe emails if they want to.

There isn't, it's the condescending rhetoric and insults that are the problem.

By the way @thegrb93 say that to @ExtReMLapin who managed to be even more condescending than Gmod devs themselves. Just ridiculous bashing with no point at all. I might look a big judgmental, but I do it with arguments and the hope to help in the end. Truth and honesty isn't meant to be kind or nice, it is what it is, and it usually helps more than just buying into anything others are doing which doesn't help at all.

robotboy655 commented 4 years ago

Yeah, closing this.

@UltimateByte Please accept my apologies if my behavior is not up to your standards. I can only try to be better,