Facepunch / garrysmod-requests

Feature requests for Garry's Mod
85 stars 24 forks source link

Stop Failed to Load spam. #783

Closed NanoAi closed 8 years ago

NanoAi commented 8 years ago

When something fails to load the game should stop trying to constantly load it again unless there has been an update to the files. I often find that things like this cause massive amounts of lag.

Maybe have some non-annoying non-intrusive error sound to replace sounds that can't be found just like the ERROR model replaces models that can't be found?

Edit: This is not about the errors being spammed but more about the lag that comes with them.

Kefta commented 8 years ago

I think an error sound would be too obnoxious, but :+1: for showing the missing message only once

LonelyWolf-GitHub commented 8 years ago

6ody

It causes huge FPS drops, there should be a console variable added to disable loading something that is not there, or maybe something like @LuaTenshi said.

NanoAi commented 8 years ago

Making a console variable wouldn't work because of https://github.com/Facepunch/garrysmod-requests/issues/358 and https://github.com/Facepunch/garrysmod-requests/issues/269

Instead it should be like I suggested above. "Sound failed to load? Notify the user, and lets not attempt to load it again unless there is a file update or the user rejoins."

LonelyWolf-GitHub commented 8 years ago

Yea, that would work much better and probably be smoother.

robotboy655 commented 8 years ago

You can already disable any console message with the console filter convars:

con_filter_enable 1
con_filter_text_out "Failed to load"

This warning will not be removed, you don't hide your errors, you fix them.

NanoAi commented 8 years ago

I mean the errors are not that annoying. The problem is that your fps drops hard. Even when not in the console. (Imagine joining a sandbox server and being fine with seeing errors but not wanting to download a million files.)

I assume the performance drop is from the game constantly trying to load a file that doesn't exist not from the error it self. (Edited main post to reflect this.)

I will try to do the above and see if the fps/lag issue still happens.

Also I wasn't talking about removing the error or message but was talking about having it not spam the console like it does currently.

Bletotum commented 8 years ago

robotboy, you should read more carefully the issue isn't that anyone wants error messages removed, but that the event causing the error (the missing file trying to load) is supposedly the cause of the lag and should not occur multiple times

if this is false and the console error message is the culprit of the lag, then the message should only display once per missing file per session