Facepunch / sbox-spritetools

MIT License
8 stars 2 forks source link

Sprites don't cast shadows. #12

Open badandbest opened 2 months ago

badandbest commented 2 months ago

Describe the issue

The 2D Sprite Component has a "Cast Shadows" property. image

Despite this, the sprites don't cast shadows. image

Expected behaviour

In #2, the attached image does cast shadows. Was it removed? image

Additional Context

I figured maybe I wasn't on the right branch, so I switched to tilemap-tools and the issue still presists.

CarsonKompon commented 2 months ago

I'll look into this. I would suspect this has something to do with recent shader changes

On Tue, Aug 6, 2024, 7:10 AM badandbest @.***> wrote:

Describe the issue

The 2D Sprite Component has a "Cast Shadows" property. image.png (view on web) https://github.com/user-attachments/assets/b98b83e0-0b4e-4505-8a44-2623063381ed

Despite this, the sprites don't cast shadows. image.png (view on web) https://github.com/user-attachments/assets/b0b6b284-4d41-4a1a-a2e5-b94fc469c098 Expected behaviour

In #2 https://github.com/Facepunch/sbox-spritetools/issues/2, the attached image does cast shadows. Was it removed? image.png (view on web) https://github.com/user-attachments/assets/ace4de31-7e86-4090-b92c-82bdd3fe4e86 Additional Context

I figured maybe I wasn't on the right branch, so I switched to tilemap-tools and the issue still presists.

— Reply to this email directly, view it on GitHub https://github.com/Facepunch/sbox-spritetools/issues/12, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHLTSNBVKUKAPTRJ5TM3ADZQCVLXAVCNFSM6AAAAABMCDEFZGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2TANRRGI2TGMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

CarsonKompon commented 2 months ago

So this seems to be a s&box issue as I initially believed. Until then I have pushed a temporary fix that will draw shadows, but they won't be affected by opacity until a proper fix is issued 👍

badandbest commented 2 months ago

That's perfectly fine for my use case 👍