search

FacetWP / use-child-theme

A WordPress class to ensure that a child theme is installed and active
65 stars 21 forks source link

Text domain #14

Closed webmandesign closed 7 years ago

webmandesign commented 8 years ago

As far as I know, there should be only 1 text domain used in a WordPress theme.

So, I suggest renaming the text domain in the script from use-child-theme to parent-theme-slug (or similar) and making a note in description that theme developer should change this text domain to match the (parent) theme (where this script is included) slug.

What do you say?

PS: I'm not really a fan of modifying scripts included in the theme, but this is the only way we can resolve this issue I think.

mgibbs189 commented 8 years ago

See #15 - would you agree that adding a filter to control the textdomain would be the best approach?

I wasn't aware that text domains could even be dynamically generated...

webmandesign commented 8 years ago

I have commented on #15

Still keeping this issue open as I really think #15 is wrong approach.

webmandesign commented 8 years ago

Seems like scripts included within themes have to be edited anyway. Another example is TGM Plugin Activation script which allows you to configure it before you download.

There doesn't have to be a configurator here, but we should document it.