FacilMap / facilmap

FacilMap is a privacy-friendly, open-source versatile online map that combines different services based on OpenStreetMap and makes it easy to find places, plan trips and add markers, lines and routes to custom maps with live collaboration.
https://facilmap.org/
GNU Affero General Public License v3.0
321 stars 21 forks source link

When saving a map view should also save the route #190

Closed tio-trom closed 3 years ago

tio-trom commented 3 years ago

Say I make a map + route + layers and POIs. I save it. But now I cannot see my saved route. Is that intentional or a bug? Cheers!

cdauth commented 3 years ago

It's intentional. You need to add the route as a line to persist it on the saved map.

I know that this is a bit confusing, since it's not really clear what is saved on the map and what is just displayed temporarily. I have not been able to find a way to improve this so far.

tio-trom commented 3 years ago

I see. Is it no possible to export the GPX tracks/routes to the server and attach that to the saved view?

cdauth commented 3 years ago

I'm not sure what exactly you mean. When you you save a route/track as a line on a collaborative map, the track is saved on the server. It can also be exported as a GPX from there.

A saved view only decides how a saved map is shown, not what is on the map. If a line is saved on the map, it will be shown as part of any saved view, unless that view explicitly hides it using a filter.

tio-trom commented 3 years ago

Ok. Likely I do not understand how this works. I was wondering why it cannot save the routes somehow...Can't you save a route as a line?

cdauth commented 3 years ago

Could you explain in more detail what exactly you are doing and what exactly you are trying to achieve?

tio-trom commented 3 years ago

I am creating a route, from point A to point B. I may add more stops on the way, markers and such. When I click to save the view I expect all that is on the map to be saved, but as far as I can tell, it will save the markers and map style and position, but not my route.

cdauth commented 3 years ago

What I'm not completely sure about is what do you mean by "creating a route". I assume you are using the route form to calculate a route and then drag it around.

Afterwards, if you click on "Add to map" and then "Line", this route will be persisted on the map.

cdauth commented 3 years ago

Here is an example: https://docs.facilmap.org/users/lines/#add-a-route-as-a-line

cdauth commented 3 years ago

Routes are only temporary, while lines are persisted on the map. The reason why there is this separation is that sometimes you want to calculate a route temporarily, for example to find out the distance between two markers that are persisted on the map or your location and a marker on the map, but you don't want to persist the route on the map for others to see (or might not even have permission to modify the map).

tio-trom commented 3 years ago

Ahhh I completely missed that and I've read the documentation. I didn't realize it. I am sorry. This is perfect. Damn you really made this map super useful and wonderful. Thank you so much! I will close this issue as it is not an "issue".

tio-trom commented 3 years ago

Maybe what I would suggest is that if anyone creates a route and then saves the view, ask them to add the route as a line on the map and save that too. together with markers and all that. Currently I only see the option to save POIs.

cdauth commented 3 years ago

That wouldn't make a lot of sense to me. The POIs are not saved on the map when you save a view. The view simply stores the view settings for the current map, and it can store which POI types you have enabled in the same way as it stores which map styles or filters you have enabled.

Saving markers and lines along with a view would create the impression that they are saved as part of the view, not of the whole map. But saved markers and lines are always part of the whole map.

tio-trom commented 3 years ago

I understand, makes sense. Thank you for the explanation!