FacilMap / facilmap

FacilMap is a privacy-friendly, open-source versatile online map that combines different services based on OpenStreetMap and makes it easy to find places, plan trips and add markers, lines and routes to custom maps with live collaboration.
https://facilmap.org/
GNU Affero General Public License v3.0
321 stars 21 forks source link

support leaflet.markercluster for big data #53

Closed pmgouveia closed 7 years ago

pmgouveia commented 7 years ago

yep... im using a script to import data to a facilmap... and kaboom it crashes..

it has 3.000 points only. markercluster is an easy option!

cdauth commented 7 years ago

Good idea, I didn’t know about it!

Would it be possible for you to share a link to a FacilMap that crashes? (For example the read-only link to your map)

pmgouveia commented 7 years ago

ei, i was trying to implement this but i didn't find a good way to debug the frontend. here is my first approach! https://github.com/pmgouveia/facilmap2/tree/markercluster

pmgouveia commented 7 years ago

my map is localhost, i implemented a script to import a csv file... to a default pad! it only works for mysql because i was to lazy to check how to implement it with sequelize.

https://github.com/pmgouveia/facilmap2/tree/oilmap/scripts

you can download the data from https://incidentnews.noaa.gov/raw/index

pmgouveia commented 7 years ago

I was able to run it now.. ! it was just about running npm run build before refreshing the browser...

cdauth commented 7 years ago

Hey, thanks for the contribution. I used your code with some modifications.

I made the feature optional, as in some maps that I am using, the marker cluster would be very annoying. So there is a checkbox in the Map Settings now where you can enable it.

The feature is in the source code already, but not on https://facilmap.org/ yet (as there is trouble with the Dockerfile right now). I will install it there soon.

pmgouveia commented 7 years ago

yay i made a branch tryin to solve docker stuff not finished though :/

On 26 de Fevereiro de 2017 16:28:55 CET, Candid Dauth notifications@github.com wrote:

Hey, thanks for the contribution. I used your code with some modifications.

I made the feature optional, as in some maps that I am using, the marker cluster would be very annoying. So there is a checkbox in the Map Settings now where you can enable it.

The feature is in the source code already, but not on https://facilmap.org/ yet (as there is trouble with the Dockerfile right now). I will install it there soon.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/FacilMap/facilmap2/issues/53#issuecomment-282563616

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

cdauth commented 7 years ago

The Dockerfile should be working again.

Note that the file structure has changed quite a lot in the last couple of days, so it might be difficult to merge your changes.

cdauth commented 7 years ago

Marker clusters are now available on https://facilmap.org/