search

FacilMap / facilmap

FacilMap is a privacy-friendly, open-source versatile online map that combines different services based on OpenStreetMap and makes it easy to find places, plan trips and add markers, lines and routes to custom maps with live collaboration.
https://facilmap.org/
GNU Affero General Public License v3.0
320 stars 21 forks source link

add oauth auth #98

Open Svetlana-T opened 6 years ago

Svetlana-T commented 6 years ago

If someone wishes to spam a collaborative map, there is only last 50 edits available for moderation. IP or username of the contributor are not shown. Is this correct? If this is correct, then it is an issue, I think.

https://www.mediawiki.org/wiki/Help:OAuth may be used.

cdauth commented 6 years ago

That is correct.

I think the easiest way to solve this is to improve the functionality of the history. So for example to save an unlimited number of modifications, to visualise modifications better, to provide a way to revert all modifications up to a certain time...

Adding authentication to FacilMap is a complex task and will add a lot of complexity to the application (and with it potential security holes). The inspiration for FacilMap comes from Etherpad, which is a text editor with the same approach, whoever has the link can make changes.

Actually I don't see so much benefit of adding authentication regarding spam. A user could still register and spam everything. The question of how to identify multiple modifications by the same user could be done in a much simpler way (like for example by storing the IP address, as you suggested).

Also I don’t understand what you think OAuth could be useful for? It is normally used to do something with a user’s account on another website.

So my proposal would be to collect ideas how the modification history could be improved, rather than adding authentication to the map. What do you think? Anyways I am travelling until mid-October and cannot work on anything until then.

Svetlana-T commented 6 years ago

Thank you for this detailed response cdauth. It is nice to hear back from you and see what you think. :)

OAuth means some spammer IPs like open proxies would be unable to spam because they are blocked on-wiki. Hence the suggestion. I still agree with the other improvements to modification history which you suggested above.