search

FactbirdHQ / atat

no_std crate for parsing AT commands
Apache License 2.0
115 stars 31 forks source link

Re-exporting of types used in Clock #118

Closed dbrgn closed 2 years ago

dbrgn commented 2 years ago

The Clock type is a re-export of fugit_timer::Timer. This is a nice convenience feature (because I don't need to depend on fugit), but if I actually want to implement the timer trait, I also need access to other types, namely fugit::Instant and fugit::Duration.

I'd suggest either moving the Clock trait to a separate module and re-exporting Instant and Duration in that module as well (e.g. atat::clock::{Clock, Instant, Duration} or alternatively re-exporting fugit at the top level.

MathiasKoch commented 2 years ago

Both of those approaches sounds reasonable to me.