search

FactbirdHQ / atat

no_std crate for parsing AT commands
Apache License 2.0
109 stars 29 forks source link

Enable external client implementations by making response_channel pub #158

Closed ijager closed 1 year ago

ijager commented 1 year ago

I want to use atat with an rtic v2 project instead of embassy. Therefore I implemented my own async Client that does not depend on embassy_time. In order to have my own specific client implementation outside of the atat crate I need to access response_channel. So I have made it public.

I feel like this is preferable over having many specific client implementations in atat.

rmja commented 1 year ago

This is good idea. Maybe we should include the urc channel while we are at it? I have needed this elsewhere when writing custom driver at tests.

MathiasKoch commented 1 year ago

LGTM :+1: Thanks