FactbirdHQ / mqttrust

MQTT client for embedded devices, written in rust
53 stars 5 forks source link

Use embedded-time and keep track on inflight outgoing messages #21

Closed keisrk closed 3 years ago

keisrk commented 3 years ago

Currently the content of outgoing_pub buffer is not utilized. By attaching a timestamp to each inflight message, we can judge when to re-try publishing it again, or discard as no puback received.

codecov-io commented 3 years ago

Codecov Report

Merging #21 (bd366a3) into master (b51eee9) will decrease coverage by 0.38%. The diff coverage is 15.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   45.57%   45.19%   -0.39%     
==========================================
  Files           5        5              
  Lines         531      551      +20     
  Branches      151      142       -9     
==========================================
+ Hits          242      249       +7     
- Misses        211      229      +18     
+ Partials       78       73       -5     
Impacted Files Coverage Δ
src/eventloop.rs 23.11% <7.14%> (-0.36%) :arrow_down:
src/lib.rs 30.55% <14.28%> (+0.55%) :arrow_up:
src/state.rs 39.69% <22.85%> (+0.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a95e47...bd366a3. Read the comment docs.

MathiasKoch commented 3 years ago

Is this PR ready?

keisrk commented 3 years ago

Yes it is:)

MathiasKoch commented 3 years ago

It seems to be getting Disconnecting from handshake timeout! constantly.. I will fix this part, while you continue on the QoS1 PR

keisrk commented 3 years ago

Thanks a lot:)