search

FactbirdHQ / mqttrust

MQTT client for embedded devices, written in rust
53 stars 5 forks source link

Split trait from its implementation #29

Closed keisrk closed 3 years ago

keisrk commented 3 years ago
  1. Split work spaces and moves source files (version bump 0.0.6)
  2. Rename the impl struct to Client

fixes #26

codecov-commenter commented 3 years ago

Codecov Report

Merging #29 (21b31aa) into master (56987ec) will increase coverage by 0.07%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   54.24%   54.32%   +0.07%     
==========================================
  Files           5        6       +1     
  Lines         577      578       +1     
  Branches      141      140       -1     
==========================================
+ Hits          313      314       +1     
  Misses        174      174              
  Partials       90       90
Impacted Files Coverage Δ
mqttrust/src/requests.rs 87.50% <ø> (ø)
mqttrust_core/src/eventloop.rs 39.10% <ø> (ø)
mqttrust_core/src/lib.rs 30.55% <ø> (ø)
mqttrust_core/src/options.rs 100.00% <ø> (ø)
mqttrust_core/src/state.rs 48.38% <0.00%> (ø)
mqttrust/src/lib.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56987ec...21b31aa. Read the comment docs.

MathiasKoch commented 3 years ago

The one thing i think might make this more ergonomic to use, would be to re-export mqttrust from mqttrust_core?

Could you also create the corresponding draft PR in rustot to switch to only relying on mqttrust, and the draft in factbird-mini, to rely on mqttrust_core?

keisrk commented 3 years ago

Sure thing:)