FactbirdHQ / ublox-cellular-rs

A driver crate for the entire u-blox cellular family in Rust
21 stars 10 forks source link

fix sara-r5 #89

Closed tarfu closed 1 year ago

tarfu commented 1 year ago

Related to #88.

tarfu commented 1 year ago

It does compile for me now, with features sara-r5 and defmt-impl. I can't get it to run properly, but if it does need changes, I would open another PR. But I can also collect all changes until it works here if that is better for you.

tarfu commented 1 year ago

Would also add https://github.com/BlackbirdHQ/atat/pull/171 to here

tarfu commented 1 year ago

Also will add this here https://github.com/BlackbirdHQ/ublox-sockets/pull/18 so that the versions are in sync

tarfu commented 1 year ago

@MathiasKoch I think this could be merged. It builds and seems to work. I would open another PR to bring it to live on embassy with only one executor and add some async functions for everything that writes stuff or has sleeps.

Currently, it sends plenty of commands to init AT, but then the ingress would only read them after it is too late.

tarfu commented 1 year ago

The async one could be a real big PR looking into it this evening. ...

MathiasKoch commented 1 year ago

Closes https://github.com/BlackbirdHQ/ublox-cellular-rs/issues/88

MathiasKoch commented 1 year ago

@tarfu Could you make the CI green :)

tarfu commented 1 year ago

@MathiasKoch Should be done.