search

FacticiusVir / SharpVk

C# Bindings for the Vulkan API & SPIR-V
MIT License
147 stars 18 forks source link

Missing 0–extern subpass dependency in HelloTriangle #19

Closed krOoze closed 8 years ago

krOoze commented 8 years ago

HelloTriangle(UWP) is missing "output"(0–extern) subpass dependency making swapchain image "available" for the presentation.

FacticiusVir commented 8 years ago

Is this referring to https://github.com/FacticiusVir/SharpVk/blob/UWP/SharpVk/SharpVk.HelloTriangle.Uwp/MainPage.xaml.cs#L347 or have I misunderstood?

krOoze commented 8 years ago

^ yes that. It has external–0 dependency, but no 0–external.

krOoze commented 8 years ago

@FacticiusVir You seem to have src and dst parameters swapped in the added dependency.

FacticiusVir commented 8 years ago

For the stage masks?

krOoze commented 8 years ago

Both stage and access masks. Bottom+read seems to be for the following present and such should be in dst for the output dependency. And the color_att_output+color_att_write should be source.

FacticiusVir commented 8 years ago

Fair does, I still need to read up on subpass dependencies; thanks for the catch!