search

FacticiusVir / SharpVk

C# Bindings for the Vulkan API & SPIR-V
MIT License
147 stars 18 forks source link

DeviceMemory.MapMemory has ref parameter, could be out or return value. #37

Closed Dykam closed 6 years ago

Dykam commented 6 years ago

DeviceMemory.MapMemory has ref IntPtr data, this seems more appropriate to be either an out parameter or a return value.

FacticiusVir commented 6 years ago

Entirely agree; this is changed to a return value in v0.4.0 - https://github.com/FacticiusVir/SharpVk/blob/4519620ad741c7d398fb47387ecb3b5c46bc566b/src/SharpVk/DeviceMemory.gen.cs#L79

Dykam commented 6 years ago

My bad, I forgot to look in the (unpublished) code.

FacticiusVir commented 6 years ago

No worries; I need to start tidying up the repo now that most of the code is ported.