search

Factlink / pavlov

Provides a Command/Query/Interactor framework.
MIT License
22 stars 4 forks source link

validate should raise when input is invalid #26

Closed marten closed 11 years ago

marten commented 11 years ago

maybe we want to change this behaviour later, but for now the interface should be consistent between when we use valid? and validate.

marten commented 11 years ago

Should this not have changed the specs?

coveralls commented 11 years ago

Coverage Status

Coverage decreased (-0%) when pulling 2a6e20a932d234deb2e4da9534163f24612feb99 on feature/raise-on-invalid into a2870292d5e30c73ffe12c33d045c4615b62ebed on master.

marten commented 11 years ago

@markijbema Should this not have changed the specs?

markijbema commented 11 years ago

Yes, there is a missing spec in here somewhere. I just noted the bug, and jotted down the solution, since it was easier than filing an issue explaining it.

marten commented 11 years ago

Implemented with tests with https://github.com/Factlink/pavlov/commit/edf71c9de3853c8992814c9b8c550ac45bcddd05

markijbema commented 11 years ago

:+1:

jjoos commented 11 years ago

nice