search

Factlink / pavlov

Provides a Command/Query/Interactor framework.
MIT License
22 stars 4 forks source link

Feature/consistent naming #58

Closed marten closed 10 years ago

marten commented 10 years ago

With regards to #57, it is possibly an easier upgrade if we rename everything first, which is probably an easy one-off search-and-replace.

What do you folks think? We could do a small release with this step first, so that everything is prepared for #57 and possibly other things down the line.

markijbema commented 10 years ago

I'm all for renaming, but I don't like the semantics of this operation. validate shouldn't be required to return a boolean imho. But I think authorized? should. That's also why I don't think authorized? shouldbe renamed.

marten commented 10 years ago

Fair enough. I've rebased dropping the authorized? change.

marten commented 10 years ago

We're now raising for missing attributes, but valid? catches and returns false instead. It's not completely the same as before, but I don't think anybody calls valid? yet so probably makes no difference? @markijbema can you confirm?