Added validations for less_than and greater_than

Factlink / pavlov

Provides a Command/Query/Interactor framework.

MIT License

22 stars 4 forks source link

Added validations for less_than and greater_than #6

Closed michiel3 closed 11 years ago

michiel3 commented 11 years ago

validate_greater_than(param_name, param, compare) validate_greater_than_or_equal_to(param_name, param, compare)

validate_less_than(param_name, param, compare) validate_less_than_or_equal_to(param_name, param, compare)

Couldn't find any tests that actually test if the validations work like expected. I think we should add this to the test suite soon!

markijbema commented 11 years ago

Then please start by writing tests for these.

RSO commented 11 years ago

I tried adding tests for these but got stuck with MiniTest, spoke with @jjoos on this and we decided to move to RSpec, which I hope to do this weekend.

jjoos commented 11 years ago

@markijbema The rails validators that we will convert to have a nice test suite. They're in the other 'rails' branch.