search

Factlink / pavlov

Provides a Command/Query/Interactor framework.
MIT License
22 stars 4 forks source link

Conversion between lowercase and uppercase is annoying #7

Closed janpaul123 closed 11 years ago

janpaul123 commented 11 years ago

Why should we want to type query :user_by_id instead of query :UserById, while the class is called UserById? It makes it hard when searching through the code as both formats have to be searched.

jjoos commented 11 years ago

@markijbema Why did you that? :P

markijbema commented 11 years ago

Most ruby code seems to do it, so i did as well. Imho it's more readable as well. I find camelcased text way less readable than snakecased, at least. Also, this convention does not tie it as strictly to our current class structure, as we might change that later, and inject other types of commands/queries/interactors, which needn't necessarily need to follow this class construction (ie. what we discussed two weeks ago).

michiel3 commented 11 years ago

Unsure why my comment is gone, but that's indeed what I meant with 'Ruby style'.

marten commented 11 years ago

If we're going to refer by symbol, then yeah I think underscores are the way to go. I don't think I've seen a camelcased symbol ever before. I agree on the search issue though, but I don't think the proposed style is the solution.

marten commented 11 years ago

I'm closing this issue. We'll keep this in mind while designing the Backend API, although I can't promise we'll actually use camelcase.