search

FactomProject / factom

Library for writing Factom clients in go
MIT License
44 stars 19 forks source link

Rcd e #133

Closed Emyrk closed 4 years ago

PaulBernier commented 4 years ago

@Emyrk could you give us the context of this PR? What was the motivation and end purpose? @WhoSoup we have removed wallet folder from this lib, I don't think we will be able to recover this PR, but we may need to port it to factom-walletd repo, if relevant.

WhoSoup commented 4 years ago

@Emyrk could you give us the context of this PR? What was the motivation and end purpose?

RCD-e is the ethereum addresses that are needed for the factom<->ethereum gateway. PegNet also uses them for its gateway and right now, the pegnet project uses emyrk's fork as factom lib.

RCD-e isn't inside factomd yet since this would be a hard fork, so the PR likely would have just idled until then.

PaulBernier commented 4 years ago

Good to know this is beeing used, gives some confidence in the testing. @Emyrk are you willing to help us make the extra push to get this merged into develop? By that I mean resolve conflicts and address potential review commets. It's totally fine to say no if don't want to, but we need to know if we need to re do that PR ourselves or not. Thank you.

PaulBernier commented 4 years ago

Sounds like we won't be able to move forward with this PR... I created an issue to track that feature request https://github.com/FactomProject/factom/issues/148