search

FactomProject / factomd

Factom Daemon
https://www.factomprotocol.org/
Other
201 stars 92 forks source link

Who wax #1013

Closed stackdump closed 4 years ago

stackdump commented 4 years ago

Who's changes - but had to revert blocktime channel

stackdump commented 4 years ago

didn't really figure out why that change had to be reverted - was the first thing I tried

WhoSoup commented 4 years ago

but had to revert blocktime channel

Could you elaborate on this?

stackdump commented 4 years ago

but had to revert blocktime channel

Could you elaborate on this?

Oh tests were failing until I reverted https://github.com/FactomProject/factomd/pull/1013/commits/8861ccf24ad8d29728c9f092753c52697549340c

Seems like there's a duplicate channel registered - may just be a testing issue if build is working as-is.

PaulBernier commented 4 years ago

@WhoSoup could you clarify where this PR stands relative to the Wax release? Does this PR needs to be rebased and re-tested? Also the ControlPanel code was added back to this branch instead of the wax rollup, so if we are not merge this PR we will need to get it back in the wax rollup. Thanks

WhoSoup commented 4 years ago

@WhoSoup could you clarify where this PR stands relative to the Wax release? Does this PR needs to be rebased and re-tested? Also the ControlPanel code was added back to this branch instead of the wax rollup, so if we are not merge this PR we will need to get it back in the wax rollup. Thanks

I think it's just a rollup branch of my other PRs + Matt's commit. I pointed the CP PR at this one because it relied on multiple previous PRs in order to be able to test it. I'll see if I can rebase it

PaulBernier commented 4 years ago

Ok I compared with wax_rollup branch, and there are only 2 things missing from here in wax branch: