remove isCompilerVersionOK check

FactomProject / factomd

Factom Daemon

https://www.factomprotocol.org/

Other

201 stars 92 forks source link

remove isCompilerVersionOK check #1048

Closed PaulBernier closed 4 years ago

PaulBernier commented 4 years ago

I upgraded my local setup to go 1.15. As a side effect it looks like it has better static analysis and complained about some string conversion, and for good reason, so I fixed that. Finally, do not disable vet for tests.

WhoSoup commented 4 years ago

Thoughts on just removing the whole isCompilerVersionOK() functionality? Seems like it's mostly an annoyance for developers and we don't actually guarantee go compatibility down to version 1.7. We'd have to run unit tests for all listed versions for each release and afaik, we don't. ANOs use the docker image, which has a go version specified.

PaulBernier commented 4 years ago

Agreed, I removed that check