Remove bogus "MinuteNumber.GetSigHash() returned a nil for IHash" error.

FactomProject / factomd

Factom Daemon

https://www.factomprotocol.org/

Other

201 stars 92 forks source link

Remove bogus "MinuteNumber.GetSigHash() returned a nil for IHash" error. #1053

Closed PaulSnow closed 4 years ago

PaulSnow commented 4 years ago

GitSigHash() isn't defined for MinuteNumber, so it always returns a nil. It shouldn't be checked. MinuteNumber.GetSigHash() returned a nil for IHash. Called from goroutine 7220-/common/entryCreditBlock/minutenumber.go:74

PaulSnow commented 4 years ago

Already fixed in develop

PaulBernier commented 4 years ago

To be exact it has been fixed in Wax branch (https://github.com/FactomProject/factomd/pull/1021) but not develop (until we merge Wax into develop that is)