search

FactomProject / factomd

Factom Daemon
https://www.factomprotocol.org/
Other
201 stars 92 forks source link

remove references to glide (#1046) #1099

Closed PaulBernier closed 3 years ago

PaulBernier commented 3 years ago

cherry-pick https://github.com/FactomProject/factomd/commit/b888bfaac9e12099f9e2045c45b27d2222908360

WhoSoup commented 3 years ago

The test that failed here is from the events module, specifically eventservices, which fails because in the event test file, there's an init() function that parses command line flags, which messes with unit tests, which parse their own parameters:

https://github.com/FactomProject/factomd/blob/fd60c1fb7aab41d8c711cf704f1acfbb83a49f60/events/eventservices/eventSim_test.go#L41-L49

At first glance, these tests seem to be intended to run externally with a separate simulated instance of factomd? If so, it might be okay to exclude that directory.

PaulBernier commented 3 years ago

Thanks for the initial investigation @WhoSoup . I decided to just rename the method so it doesn't start with Test* and is not considered an automated test anymore.