search

Factor-Robotics / odrive_ros2_control

ODrive driver for ros2_control
Apache License 2.0
270 stars 83 forks source link

migrating to humble from foxy #20

Closed ryanpennings closed 2 years ago

ryanpennings commented 2 years ago

I'm trying to move over to humble, and I've managed to get all the return types fixed (as seen in #11) - I made 2 check functions, not sure that's the best way to go about it..

However, now I'm getting this error: image

https://github.com/MSDRobotics/odrive_ros2_control/tree/devel/odrive_hardware_interface

Anyone have any ideas?

borongyuan commented 2 years ago

I just installed ROS Humble recently. We plan to continue updating this project from next month. Looking forward to your contributions :)

ryanpennings commented 2 years ago

Thanks, I'm hoping to implement CAN after this too.

ryanpennings commented 2 years ago

I was able to fix it by adding const rclcpp::Time & time, const rclcpp::Duration & period to the read and write functions, as seen in this example: https://github.com/ros-controls/ros2_control_demos/blob/master/ros2_control_demo_hardware/include/ros2_control_demo_hardware/diffbot_system.hpp

maxpolzin commented 2 years ago

Nice @ryanpennings. Does that mean your branch is working for humble?

ryanpennings commented 2 years ago

Nice @ryanpennings. Does that mean your branch is working for humble?

It builds, but I haven't tested it yet.