search

Factor-Robotics / odrive_ros2_control

ODrive driver for ros2_control
Apache License 2.0
250 stars 82 forks source link

Fix pkg_search_module #23

Closed lukicdarkoo closed 1 year ago

lukicdarkoo commented 1 year ago

Fixes:

CMake Error at CMakeLists.txt:21 (pkg_search_module):
  Unknown CMake command "pkg_search_module".
borongyuan commented 1 year ago

Hi, have you tested this package on Windows? Usually this line is not necessary for Linux. I've only heard of such problems on Windows. So I am curious about your development environment.

lukicdarkoo commented 1 year ago

I had the issue on Ubuntu 22.04 in a Docker container

borongyuan commented 1 year ago

Thanks, I can finally reproduce this issue. I think this issue is not related to Docker. It's just that several Docker images I know have switched to Cyclone DDS. If the environment variable "RMW_IMPLEMENTATION=rmw_cyclonedds_cpp" is set, you will encounter this problem when compiling. As odd as it is, it is true. ROS2 developers have encountered quite a few strange problems with DDS. We'll take a closer look at what this is all about later.

lukicdarkoo commented 1 year ago

Thanks, I can finally reproduce this issue. I think this issue is not related to Docker. It's just that several Docker images I know have switched to Cyclone DDS. If the environment variable "RMW_IMPLEMENTATION=rmw_cyclonedds_cpp" is set, you will encounter this problem when compiling. As odd as it is, it is true. ROS2 developers have encountered quite a few strange problems with DDS. We'll take a closer look at what this is all about later.

Good catch, I was using Cyclone DDS but I didn't think it was worth of mentioning.

@avielbr I implemented reversing and it was working fine, but deleted it eventually as it makes the implementation ugly. I simply switched the wires on ODrive