Factorio-Access / FactorioAccess

An accessibility mod for the video game Factorio, making the game accessible to the blind and visually impaired.
Other
14 stars 8 forks source link

Menu search: After searching the player inventory from inside a building, searching output sector returns player inventory results instead. #164

Closed LevFendi closed 2 days ago

LevFendi commented 1 month ago

1. Describe the bug

Menu search: After searching the player inventory from inside a building, searching output sector returns player inventory results instead. This occurs in the unreleased code that fixes #116. The SHA is 4ef8c4c5c3f3ea3c70ce8e1648476712e74398ca . The menu is definitely the output menu, though, as verified with SHIFT + E or using arrow keys.

2. Steps to Reproduce

  1. Open a building menu
  2. Switch to the player
  3. Run any menu search.
  4. Switch FORWARD to the building output sector (switching backward does not cause this).
  5. Run menu search again without resetting the search term.

3. Expected correct behavior

You should be getting results for the building output sector but you get the ones for the player inventory sector.

4. Mod version

This change will be coming to next-update before version 0.11.3.

5. Additional context

I spent a good while comparing the code for switching menus forward and backward but I could not spot a relevant difference. I will get back to this bug later. For now it is good to have menu search at all.

LevFendi commented 2 days ago

Fixed in 0.12.2