minor fixes - Githubissues

Factorio-Access / FactorioAccess

An accessibility mod for the video game Factorio, making the game accessible to the blind and visually impaired.

Other

14 stars 8 forks source link

minor fixes #171

Closed ctoth closed 2 weeks ago

ctoth commented 2 weeks ago

Fix typo in launcher locale
Indicate that the game must be launched in order for the %appdata%\Factorio folder to appear

LevFendi commented 2 weeks ago

Hello and thank you for your contribution! I will review and merge these corrections in a few hours or days. Please feel free to share any further comments on how the install instructions and etc. can be improved.

ctoth commented 2 weeks ago

The changes look more extensive than they are because I had to renumber the list to include the new item. I recommend we switch to the convention of using 1 for each number in the list to make future alteration easier, but that felt like a larger change than I should make for this one small fix.

ahicks92 commented 2 weeks ago

If we assume the numbers shift a lot then you can't talk about them in a stable fashion anyway. Should we bother keeping them numbered at all would be my question.

LevFendi commented 2 weeks ago

The typos are all mine 😁. Thanj you for the review notes, i will be fixing accordingly.

I just tried numbering all the points as "1" and indeed markdown arranges them by itself, that is really nice. We should keep the numbering because they are very useful when troubleshooting install problems.

As for the locale file here, it is for the FA launcher, which is already mostly localized using vanilla strings. This file covers the rest and its format will help future translators by having the same format as other locale files.