FactorioBlueprints / factorio-prints

factorioprints.com
https://factorioprints.com/
188 stars 37 forks source link

Provided blueprint strings are invalid #292

Open BraydenMotion opened 3 years ago

BraydenMotion commented 3 years ago

The site freezes for a few seconds before a popup appears telling me to press CTRL+C. When I paste this code in-game, not only is it way too short to possibly the blueprint I copied, but its also invalid. This happens on factorio.school and factorioprints.com. I've tried with and without an ad blocker, with and without a tracker blocker, and nothing has changed. It has rendered the site completely unusable.

FactorioBlueprints commented 3 years ago

I have not heard other complaints, so try a force refresh and see if it still happens? Do you have an example blueprint that's bad, or are you saying it's affecting all blueprints?

On Sun, Jan 24, 2021 at 2:14 PM Brayden notifications@github.com wrote:

The site freezes for a few seconds before a popup appears telling me to press CTRL+C. When I paste this code in-game, not only is it way too short to possibly the blueprint I copied, but its also invalid. This happens on factorio.school and factorioprints.com. I've tried with and without an ad blocker, with and without a tracker blocker, and nothing has changed. It has rendered the site completely unusable.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/FactorioBlueprints/factorio-prints/issues/292, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF24KXJBLLWINO2FGZYE3PTS3RWSJANCNFSM4WQYMU6Q .

BraydenMotion commented 3 years ago

It seems like short blueprint strings copy fine. I don't know what the upper limit is since I can't copy the large strings. The small ones seem to copy without a popup and the large ones always create a popup(with an invalid string). I've noticed sometimes though the large ones don't create a popup, but pressing CTRL+C will still copy the valid blueprint. I can't figure out why this happens and it is extremely rare.

Some blueprints that copy fine are: https://www.factorio.school/view/-MFIYLSH60wmZ-pNvcL_ https://www.factorio.school/view/-Kn2afLokZdBO-uHcIAF

Some blueprints that give an invalid string are: https://www.factorio.school/view/-MNZWdWosuqr3vtaC2hD

carolluparu commented 3 years ago

The same issue occurs to me for this blueprint which Brayden said is ok though: https://www.factorio.school/view/-Kn2afLokZdBO-uHcIAF

  1. Looking through Chrome's dev tools I see that this request fails completely: GET https://www.factorio.school/api/blueprintContentTitles/-Kn2afLokZdBO-uHcIAF 400 (Bad Request) { "code" : 400, "message" : "Blueprint string could not be parsed." }

  2. Also, this points to an error on this resource missing: https://www.factorio.school/static/node_modules/axios/lib/adapters/xhr.js (404) URI: /static/node_modules/axios/lib/adapters/xhr.js

    404 Not Found ui-assets

system info: the issue reproduces on both Chrome Version 88.0.4324.150 (Official Build) (64-bit) and Edge Version 88.0.705.68 (Official build) (64-bit)

image

FactorioBlueprints commented 3 years ago

I've been rolling out a few new features and caused some temporary outages in the process. I think everything is fixed now but I'm still struggling to get Dropwizard to put accurate Last-Modified and ETag headers on index.html. The result is that users have to force refresh the page to get rid of some errors.

On Thu, Feb 18, 2021 at 5:44 PM carolluparu notifications@github.com wrote:

The same issue occurs to me for this blueprint which Brayden said is ok though: https://www.factorio.school/view/-Kn2afLokZdBO-uHcIAF

1.

Looking through Chrome's dev tools I see that this request fails completely: GET https://www.factorio.school/api/blueprintContentTitles/-Kn2afLokZdBO-uHcIAF 400 (Bad Request) { "code" : 400, "message" : "Blueprint string could not be parsed." } 2.

Also, this points to an error on this resource missing:

https://www.factorio.school/static/node_modules/axios/lib/adapters/xhr.js (404) URI: /static/node_modules/axios/lib/adapters/xhr.js

404 Not Found ui-assets

system info: the issue reproduce on both Chrome Version 88.0.4324.150 (Official Build) (64-bit) and Edge Version 88.0.705.68 (Official build) (64-bit)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/FactorioBlueprints/factorio-prints/issues/292#issuecomment-781684599, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF24KXJCF4KPNO42NXUAFHLS7WJ6FANCNFSM4WQYMU6Q .

carolluparu commented 3 years ago

Thanks for the answer. The same link that I was having issues with yesterday looks ok now and I can get the blueprint. Looking at Chrome's dev console seems better now: image